Add instrumentation to the search services #30350
Merged
+56
−21
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a start at adding custom spans to the app code. I started on this one as I noticed some weird traces when doing searches, and I wanted to have a better visibility on which kind of search was triggering this.
We need the
opentelemetry-api
to be loaded so we can call the various instrumentations methods, but if OTEL is not configured then those methods are no-ops.I created a custom
mastodon
tracer. At some point we may want to have multiple tracers to split the various parts of the app into their own instrumentations, but this can be done later once we have a better vision of what we want.cc @robbkidd