Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add instrumentation to the search services #30350

Merged
merged 1 commit into from
May 24, 2024

Conversation

renchap
Copy link
Sponsor Member

@renchap renchap commented May 17, 2024

This is a start at adding custom spans to the app code. I started on this one as I noticed some weird traces when doing searches, and I wanted to have a better visibility on which kind of search was triggering this.

image

We need the opentelemetry-api to be loaded so we can call the various instrumentations methods, but if OTEL is not configured then those methods are no-ops.

I created a custom mastodon tracer. At some point we may want to have multiple tracers to split the various parts of the app into their own instrumentations, but this can be done later once we have a better vision of what we want.

cc @robbkidd

@renchap renchap force-pushed the otel-search-instrumentation branch from b87f6de to 7aa496c Compare May 19, 2024 17:03
@renchap renchap requested a review from a team May 24, 2024 12:59
@renchap renchap added this pull request to the merge queue May 24, 2024
Merged via the queue into mastodon:main with commit acc77c3 May 24, 2024
32 checks passed
@renchap renchap deleted the otel-search-instrumentation branch May 24, 2024 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants